Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer feature: add sidebar action "Refresh directory tree" #12908

Merged
merged 2 commits into from
May 13, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Mar 3, 2024

This allows to show newly added directories when the parent had no directories when it was first added to the tree.

This works around the caching of the 'hasChildren' state of each tree item.

based on #12893

remove cached 'hasChildren' state for all sub-dirs in order to allow expanding items that
have sub-dirs added after the items have been shown the first time.
@ronso0 ronso0 marked this pull request as ready for review April 22, 2024 09:47
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following:

  • Opened a folder with Mixxx
  • Added a file using a file manager.
  • Select Refresh form the context menu.
    Expected: File is shown
    Actual: nothing happens.

@daschuer
Copy link
Member

daschuer commented May 1, 2024

Refreshing the folders works.

The menu is missing for "Quick access" folders

@daschuer
Copy link
Member

daschuer commented May 1, 2024

I have also intuitive pressed F5, but that has a different meaning.

@ronso0
Copy link
Member Author

ronso0 commented May 2, 2024

The menu is missing for "Quick access" folders

I added that.

@ronso0
Copy link
Member Author

ronso0 commented May 2, 2024

Yeah, F5 in the tracks view would also be cool.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Works good

@daschuer daschuer merged commit 9ef40ff into mixxxdj:main May 13, 2024
13 checks passed
@ronso0 ronso0 deleted the browse-refresh-dir-tree branch May 14, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants